Add killed player's names to screenshot filenames. #6338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abextm
requested changes
Nov 4, 2018
| chatMessage = chatMessage.replace(killMessage, ""); | ||
| } | ||
| } | ||
| for (String killMessageTrim:KILL_MESSAGE_TRIM) |
There was a problem hiding this comment.
this won't work if the player's name contains any of these strings
There was a problem hiding this comment.
Ah yeah, jumped the gun on this one thinking I had a solid solution. I'll give it another look over in the morning to fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6215.
Feature adds the killed player's name to the filename, as is seen in examples below.
Also added the full set of death messages, found here via Mod Ash's twitter, credit to @NathanQuayle for pushing for that information.
Feature Demo