xp tracker: display >1m exp with higher precision #8786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderhenne
force-pushed
the
xptracker-precision
branch
from
c21d692
to
ca377c7
Compare
Adam-
reviewed
May 10, 2019
| @@ -152,6 +160,24 @@ else if (quantity < 10_000_000) | |||
| * with K after 100,000 and M after 10,000,000 | |||
| */ | |||
| public static String quantityToRSDecimalStack(int quantity) | |||
| { | |||
| return quantityToRSDecimalStack(quantity, false); | |||
There was a problem hiding this comment.
Is there anything calling this that doesn't want the more precise values? Just looks like the ge offer panel and the ammo counter.
There was a problem hiding this comment.
Well, the point of the RS decimal stack method is to format numbers exactly like OSRS formats amounts, so I think having separate method for this is good.
|
Would it be worth using an integer parameter for number of decimal digits rather than a boolean? I can envision sometime down the line some plugin or feature might want a different number of digits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users believe that the XP Tracker doesn't display experience values with enough precision when above 1m. For example, if you do skilling methods that give you between 1 and 1.1m xp/hr, it will just say 1m/hr when they want it to say e.g. "1.035m/hr".
This pull request changes the XP Tracker to display values over 1 million with higher precision.