Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xp tracker: display >1m exp with higher precision #8786

Merged
merged 1 commit into from May 11, 2019

Conversation

Projects
None yet
4 participants
@devLotto
Copy link
Member

commented May 7, 2019

Some users believe that the XP Tracker doesn't display experience values with enough precision when above 1m. For example, if you do skilling methods that give you between 1 and 1.1m xp/hr, it will just say 1m/hr when they want it to say e.g. "1.035m/hr".

This pull request changes the XP Tracker to display values over 1 million with higher precision.

@devLotto devLotto force-pushed the devLotto:xptracker-precision branch to ca377c7 May 7, 2019

@@ -152,6 +160,24 @@ else if (quantity < 10_000_000)
* with K after 100,000 and M after 10,000,000
*/
public static String quantityToRSDecimalStack(int quantity)
{
return quantityToRSDecimalStack(quantity, false);

This comment has been minimized.

Copy link
@Adam-

Adam- May 10, 2019

Member

Is there anything calling this that doesn't want the more precise values? Just looks like the ge offer panel and the ammo counter.

This comment has been minimized.

Copy link
@deathbeam

deathbeam May 10, 2019

Member

Well, the point of the RS decimal stack method is to format numbers exactly like OSRS formats amounts, so I think having separate method for this is good.

@Nightfirecat

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

Would it be worth using an integer parameter for number of decimal digits rather than a boolean? I can envision sometime down the line some plugin or feature might want a different number of digits.

@Adam- Adam- merged commit 29d79d0 into runelite:master May 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.