Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: decorate messages in vscode-lit-plugin with plugin name #108

Closed
djlauk opened this issue Jun 24, 2020 · 3 comments · Fixed by #112
Closed

Feature request: decorate messages in vscode-lit-plugin with plugin name #108

djlauk opened this issue Jun 24, 2020 · 3 comments · Fixed by #112

Comments

@djlauk
Copy link

djlauk commented Jun 24, 2020

While reviewing some code I looked at vscode's "problems" view and noticed, that the messages the lit-plugin extension adds do not have an indicator where they come from. In this screenshot you can see, how other plugins add such information:

image

(Notice the decorators "eslint(...)", "ts-styled-plugin(...)", and "ts(...)".)

In this particular case it would have helped me to quicker identify, which vscode plugin my coworker is missing.

@runem
Copy link
Owner

runem commented Jul 6, 2020

Thanks for reporting this :-)

In order to align with eslint, diagnostics will end up with this naming convention: lit-plugin(no-expressionless-property-binding).

@runem
Copy link
Owner

runem commented Jul 6, 2020

It will look like this in the future:

Screenshot 2020-07-06 at 14 32 20

@djlauk
Copy link
Author

djlauk commented Jul 6, 2020

Looks great. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants