Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add css properties to JSON output #111

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

jrobinson01
Copy link
Contributor

Add the css properties to the JSON output.
fixes #110

@web-padawan
Copy link

Thanks, and BTW this is something I also need in the <api-viewer> 👍

@web-padawan
Copy link

@runem would you have time to review this PR any time soon?

I was planning to implement CSS custom properties in the next api-viewer release.
This would be a really nice addition, and the proposed change seems good to me.

@runem
Copy link
Owner

runem commented Oct 28, 2019

Thanks for this PR @jrobinson01

I would really like to add "cssProperties" to the experimental custom-element.json format. Just to be clear: it might be removed if we land consensus on a custom-element.json format without "cssProperties" (this also applies to all other properties in the output) :-)

It might be relevant to start the discussion on adding "cssProperties" at https://github.com/webcomponents/custom-elements-json 👍

I will merge this PR and also add support for #109 when I get home from work today 🎉

@runem runem merged commit 91542c4 into runem:master Oct 28, 2019
@web-padawan
Copy link

@runem could you release this change so we can use it?

@runem
Copy link
Owner

runem commented Oct 29, 2019

I have been more caught up in work than expected this week, sorry :-/ I just released 0.1.18 with css-properties for json-format 🎉 and I will get some more time for web-component-analyzer this weekend 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

css properties missing from JSON output
3 participants