Made PartialOrderingMixin use __slots___ (fixes #10)

runfalk · Oct 25, 2017 · 722de52 · 722de52
1 parent 7e35440
commit 722de52
Show file tree

Hide file tree

Showing 3 changed files with 48 additions and 3 deletions.
diff --git a/spans/_utils.py b/spans/_utils.py
@@ -59,6 +59,8 @@ def __setstate__(self, data):
 
 
 class PartialOrderingMixin(object):
+    __slots__ = ()
+
     def __le__(self, other):
         lt = self.__lt__(other)
         eq = self.__eq__(other)

diff --git a/tests/test_range.py b/tests/test_range.py
@@ -1,7 +1,9 @@
 import pickle
 import pytest
 
-from spans import floatrange, intrange
+from spans import \
+    daterange, datetimerange, floatrange, intrange, PeriodRange, strrange, \
+    timedeltarange
 
 
 def test_empty():
@@ -523,3 +525,23 @@ def test_pickling():
 
 def test_bug7_overlap_empty():
     assert not intrange(1, 10).overlap(intrange.empty())
+
+
+@pytest.mark.parametrize("cls", [
+    daterange,
+    datetimerange,
+    intrange,
+    floatrange,
+    PeriodRange,
+    strrange,
+    timedeltarange,
+])
+def test_bug10_missing_slots_in_cls_hierarchy(cls):
+    """
+    `Bug #10 <https://github.com/runfalk/spans/issues/10>`_
+    """
+
+    for c in cls.mro():
+        if c is object:
+            continue
+        assert hasattr(c, "__slots__")
diff --git a/tests/test_rangeset.py b/tests/test_rangeset.py
@@ -1,7 +1,9 @@
 import pickle
 import pytest
 
-from spans import floatrange, floatrangeset, intrange, intrangeset
+from spans import \
+    daterangeset, datetimerangeset, floatrange, floatrangeset, intrange, \
+    intrangeset, strrangeset, timedeltarangeset
 
 
 def test_empty():
@@ -216,7 +218,26 @@ def test_bug3_intersection():
 
 def test_bug4_empty_set_iteration():
     """
-    `Bug #4 <https://github.com/runfalk/spans/issues/4>`
+    `Bug #4 <https://github.com/runfalk/spans/issues/4>`_
     """
 
     assert list(intrangeset([])) == []
+
+
+@pytest.mark.parametrize("cls", [
+    daterangeset,
+    datetimerangeset,
+    intrangeset,
+    floatrangeset,
+    strrangeset,
+    timedeltarangeset,
+])
+def test_bug10_missing_slots_in_cls_hierarchy(cls):
+    """
+    `Bug #10 <https://github.com/runfalk/spans/issues/10`_
+    """
+
+    for c in cls.mro():
+        if c is object:
+            continue
+        assert hasattr(c, "__slots__")