Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add a test for --ssh option in finch build command #101

Conversation

haytok
Copy link
Member

@haytok haytok commented Nov 17, 2023

The following pull request attempts to modify the finch build command to allow the --ssh option.

Therefore, this commit adds a test to run finch build with the --ssh option.

Issue #, if available: N/A

Description of changes: Details are described in this commit message.

Testing done: Yes

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The following pull request attempts to modify the finch build command to
allow the --ssh option.

- runfinch/finch#696

Therefore, this commit adds a test to run finch build with the --ssh
option.

Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
@mharwani mharwani merged commit f68c13c into runfinch:main Nov 21, 2023
3 checks passed
@haytok
Copy link
Member Author

haytok commented Nov 21, 2023

Thanks for merged !!!

@haytok haytok deleted the add-tests-for-ssh-option-for-finch-build-command branch November 21, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants