Skip to content

Commit

Permalink
fix: Add cleanup script to Makefile (#444)
Browse files Browse the repository at this point in the history
*Description of changes:*
Remove files under other directories besides _output, and kill running
processes for network, lima and qemu.

*Testing done:*
Tested locally


- [X] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Signed-off-by: Kevin Li <cnkevin@amazon.com>
  • Loading branch information
KevinLiAWS committed Jun 3, 2023
1 parent 741d578 commit da91f87
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/upload-installer-to-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ jobs:
aws s3 cp s3://${{ secrets.INSTALLER_PRIVATE_BUCKET_NAME }}/Finch-${{ needs.get-tag-name.outputs.tag }}-aarch64.pkg Finch-${{ needs.get-tag-name.outputs.tag }}-aarch64.pkg
aws s3 cp s3://${{ secrets.INSTALLER_PRIVATE_BUCKET_NAME }}/Finch-${{ needs.get-tag-name.outputs.tag }}-x86_64.pkg Finch-${{ needs.get-tag-name.outputs.tag }}-x86_64.pkg
aws s3 cp s3://${{ secrets.DEPENDENCY_BUCKET_NAME }}/dependency-sources.tar.gz DependenciesSourceCode.tar.gz
shell: zsh {0}
- name: Upload installers and dependency source code to release
uses: softprops/action-gh-release@v1
with:
Expand Down
6 changes: 6 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,12 @@ mdlint-ctr:

.PHONY: clean
clean:
-sudo pkill '^socket_vmnet'
-sudo pkill '^qemu-system-'
-sudo pkill '^limactl'
-sudo rm -rf "/opt/finch/"
-sudo rm -rf "/private/var/run/finch-lima"
-sudo rm -rf "/private/etc/sudoers.d/finch-lima"
-@rm -rf $(OUTDIR) 2>/dev/null || true
-@rm -rf ./deps/finch-core/_output || true
-@rm ./*.tar.gz 2>/dev/null || true
Expand Down

0 comments on commit da91f87

Please sign in to comment.