Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip markdown files in e2e tests #10

Closed
ahsan-z-khan opened this issue Nov 22, 2022 · 0 comments · Fixed by #19
Closed

Skip markdown files in e2e tests #10

ahsan-z-khan opened this issue Nov 22, 2022 · 0 comments · Fixed by #19
Assignees
@weikequ
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code

Comments

@ahsan-z-khan
Copy link
Member

Describe the bug
Markdown .md files are going through e2e-tests. It should be skipping according to this:
https://github.com/runfinch/finch/blob/main/.github/workflows/ci.yaml#L7

Steps to reproduce
Create PR with changes only in .md files

Expected behavior
.md files should be skipped during e2e tests in CI
@ahsan-z-khan ahsan-z-khan added bug Something isn't working github_actions Pull requests that update GitHub Actions code labels Nov 22, 2022
@weikequ weikequ self-assigned this Nov 22, 2022
@weikequ weikequ mentioned this issue Nov 22, 2022
Merged
1 task
weikequ added a commit that referenced this issue Nov 22, 2022
@weikequ
fix: fixed workflow doc filter (#15)
b493554 
Signed-off-by: Weike Qu <weikequ@amazon.com>

Issue #, if available:

- #10

*Description of changes:*

- Changed filter to include all .md files in the repo and on the PR.

*Testing done:*



- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Weike Qu <weikequ@amazon.com>
@weikequ weikequ linked a pull request Nov 22, 2022 that will close this issue
fix: add generic workflow for docs #19
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weikequ weikequ

Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add generic workflow for docs weikequ/finch
2 participants
@ahsan-z-khan @weikequ