fix: Fix to be able to run finch build with --ssh option #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current implementation, the following error occurs when running finch build with the `--ssh default` option. This issue is also reported in issue/452. ``` error: invalid empty ssh agent socket: make sure SSH_AUTH_SOCK is set FATA[0000] no image was built FATA[0000] exit status 1 ``` This is because the ssh agent is not starting on the vm started using lima and the SSH_AUTH_SOCK variable is empty. As a result, this error occurs. On the other hand, setting forwardAgent to true in finch.yaml will configure the vm to forward the ssh agent. As a result, the ssh agent will be started in the vm and finch build can be executed using the `--ssh default` option. Therefore, this commit will fix it so that finch build can be run using the `--ssh default` option. Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
|
Hi @haytok, is it possible to add e2e tests for |
|
Hi, @mharwani Sure, add an e2e test for the By the way, is it OK if I add the test scenario to the following test? Thanks. |
Yes, that's where the tests should go. Feel free to open a PR in that repo and tag me. Thanks |
haytok
added a commit
to haytok/common-tests
that referenced
this pull request
Nov 17, 2023
The following pull request attempts to modify the finch build command to allow the --ssh option. - runfinch/finch#696 Therefore, this commit adds a test to run finch build with the --ssh option. Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
1 task
|
Hi, @mharwani I have added an e2e test for --ssh option. When you have time, could you please review below PR ? Thanks. |
mharwani
pushed a commit
to runfinch/common-tests
that referenced
this pull request
Nov 21, 2023
The following pull request attempts to modify the finch build command to allow the --ssh option. - runfinch/finch#696 Therefore, this commit adds a test to run finch build with the --ssh option. Issue #, if available: N/A *Description of changes:* Details are described in this commit message. *Testing done:* Yes - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
|
@haytok The e2e-test is merged. Pls update github.com/runfinch/common-tests from 0.7.8 to 0.7.9 in Go modules. Thanks! |
|
Hi, @mharwani I have updated e2e test version from v0.7.8 to v0.7.9 in go.mod and go.sum. Could you please review when you have time? |
|
You need to run |
…m/runfinch/common-tests Issue #, if available: #452 *Description of changes:* This commit updates Go Modules by running go mod tidy so that we can test the --ssh option in finch build. *Testing done:* Yes - [x] I've reviewed the guidance in CONTRIBUTING.md By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
|
Thanks for the advice, I missed the |
|
Thanks for merged ! |
This was referenced Dec 4, 2023
KevinLiAWS
pushed a commit
that referenced
this pull request
Dec 7, 2023
🤖 I have created a release *beep* *boop* --- ## [1.0.1](v1.0.0...v1.0.1) (2023-12-07) ### Bug Fixes * Clean up all previous finch version installation registries in postinstall and uninstall ([#688](#688)) ([9afc0b9](9afc0b9)) * Fix to be able to run finch build with --ssh option ([#696](#696)) ([4d1e6cf](4d1e6cf)) * Fix to delete ~/.finch when uninstalling finch ([#703](#703)) ([8d7389f](8d7389f)) * remove virtual machine image when running make clean ([98c8ee4](98c8ee4)) * resolve shellcheck warnings ([#684](#684)) ([d9f695a](d9f695a)) * Use LimaUser method instead of host user name ([#712](#712)) ([7c02e08](7c02e08)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
KevinLiAWS
added a commit
that referenced
this pull request
Dec 11, 2023
🤖 I have created a release *beep* *boop* --- ## [1.0.1](v1.0.0...v1.0.1) (2023-12-11) ### Bug Fixes * Change the default behavoir for deleting .finch folder to false when uninstall ([#732](#732)) ([e818743](e818743)) * Clean up all previous finch version installation registries in postinstall and uninstall ([#688](#688)) ([9afc0b9](9afc0b9)) * Fix to be able to run finch build with --ssh option ([#696](#696)) ([4d1e6cf](4d1e6cf)) * Fix to delete ~/.finch when uninstalling finch ([#703](#703)) ([8d7389f](8d7389f)) * remove virtual machine image when running make clean ([98c8ee4](98c8ee4)) * resolve shellcheck warnings ([#684](#684)) ([d9f695a](d9f695a)) * Use LimaUser method instead of host user name ([#712](#712)) ([7c02e08](7c02e08)) ### Reverts * "fix: resolve shellcheck warnings" ([#725](#725)) ([8ea255a](8ea255a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: Kevin Li <cnkevin@amazon.com> Co-authored-by: Kevin Li <cnkevin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, the following error occurs when running finch build with the
--ssh defaultoption. This issue is also reported in issue/452.This is because the ssh agent is not starting on the vm started using lima and the SSH_AUTH_SOCK variable is empty. As a result, this error occurs.
On the other hand, setting forwardAgent to true in finch.yaml will configure the vm to forward the ssh agent.
As a result, the ssh agent will be started in the vm and finch build can be executed using the
--ssh defaultoption.Therefore, this commit will fix it so that finch build can be run using the
--ssh defaultoption.Issue #, if available: #452
Description of changes:
Details are described in commit messages.
Testing done:
Yes, confirmation of the operation is added in the comments of the issue below.
Expose SSH agent socket environment to Finch build command #452 (comment)
I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.