Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds support bundles #210

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Conversation

sam-berning
Copy link
Contributor

Signed-off-by: Sam Berning bernings@amazon.com

Issue #, if available:

Description of changes:

Allow users to generate a support bundle, a collection of Finch-related logs and configs that will help debug issues.

Testing done:

Unit & manual testing

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sam-berning sam-berning force-pushed the support-bundles branch 3 times, most recently from d2fb229 to e41a7c7 Compare February 15, 2023 01:31
@sam-berning sam-berning force-pushed the support-bundles branch 3 times, most recently from e760c11 to e4b1855 Compare March 9, 2023 01:55
@sam-berning sam-berning marked this pull request as ready for review March 11, 2023 02:23
@sam-berning sam-berning force-pushed the support-bundles branch 9 times, most recently from 5a169ef to c7706bb Compare March 24, 2023 22:21
cmd/finch/support_bundle.go Outdated Show resolved Hide resolved
cmd/finch/support_bundle.go Outdated Show resolved Hide resolved
@ningziwen
Copy link
Member

@sam-berning Need to resolve the conflict files.

Signed-off-by: Sam Berning <bernings@amazon.com>
Copy link
Member

@ningziwen ningziwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 .  o ..                  
 o . o o.o                
      ...oo               
        __[]__            
     __|_o_o_o\__         
     \""""""""""/         
      \. ..  . /          
 ^^^^^^^^^^^^^^^^^^^^ 

Copy link
Contributor

@weikequ weikequ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sam-berning sam-berning merged commit cc6be65 into runfinch:main Mar 29, 2023
sam-berning pushed a commit that referenced this pull request Mar 29, 2023
🤖 I have created a release *beep* *boop*
---


## [0.5.0](v0.4.1...v0.5.0)
(2023-03-29)


### Features

* adds support bundles
([#210](#210))
([cc6be65](cc6be65))


### Bug Fixes

* Correctly set and pick up environment variables
([#315](#315))
([05227ce](05227ce))
* print debug logs after newline
([#273](#273))
([8faa7de](8faa7de))
* print debug logs when lima disk command fails
([#270](#270))
([78a3f50](78a3f50))


### Experimental

* **feat:** enable Virtualization.framework and Rosetta
([#282](#282))
([fd3bf19](fd3bf19))


### Build System or External Dependencies

* clean up finch-core _output directory in clean target
([#290](#290))
([4684a95](4684a95))
* **deps:** bump github.com/onsi/ginkgo/v2 from 2.8.4 to 2.9.0
([#265](#265))
([7e2d49e](7e2d49e))
* **deps:** bump github.com/onsi/ginkgo/v2 from 2.9.0 to 2.9.1
([#285](#285))
([d741a03](d741a03))
* **deps:** Bump github.com/onsi/gomega from 1.27.3 to 1.27.5
([#312](#312))
([e078234](e078234))
* **deps:** bump github.com/runfinch/common-tests from 0.6.1 to 0.6.2
([#300](#300))
([dd626a0](dd626a0))
* **deps:** bump github.com/spf13/afero from 1.9.4 to 1.9.5
([#263](#263))
([a0e277f](a0e277f))
* **deps:** bump golang.org/x/crypto from 0.6.0 to 0.7.0
([#264](#264))
([ec1c07f](ec1c07f))
* **deps:** bump golang.org/x/tools from 0.6.0 to 0.7.0
([#268](#268))
([8072e39](8072e39))
* **deps:** bump k8s.io/apimachinery from 0.26.2 to 0.26.3
([#306](#306))
([fe392cb](fe392cb))
* **deps:** Bump lima version
([#302](#302))
([0269743](0269743))
* **deps:** Bump submodules
([#281](#281))
([d4fd1f6](d4fd1f6))
* **deps:** Bump submodules
([#304](#304))
([b38af9f](b38af9f))
* **deps:** Bump submodules
([#307](#307))
([1a914ec](1a914ec))
* **deps:** Bump submodules
([#319](#319))
([e671224](e671224))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants