Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump submodules and dependencies #637

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@github-actions github-actions bot force-pushed the create-pull-request/patch branch 3 times, most recently from 3fdc310 to deaf192 Compare October 24, 2023 09:05
@github-actions github-actions bot force-pushed the create-pull-request/patch branch 2 times, most recently from 8780802 to f6e0c1f Compare October 27, 2023 09:05
@pendo324 pendo324 closed this Oct 27, 2023
@pendo324 pendo324 reopened this Oct 27, 2023
@pendo324
Copy link
Member

Seems like the same failure we saw when trying to update Lima in the Windows PR (#649).

@vsiravar found the root cause to be a containerd change, which breaks our e2e tests containerd/containerd#9283

We need a nerdctl/lima change to pickup the new containerd version, but until then, I think we should remove the Lima upgrade from this PR.

ginglis13
ginglis13 previously approved these changes Oct 27, 2023
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
pendo324
pendo324 previously approved these changes Oct 30, 2023
@pendo324 pendo324 dismissed their stale review October 30, 2023 21:38

dismissing and reapproving

@pendo324
Copy link
Member

Not sure why the UI isn't allowing a regular merge now that the tests are passing. I'm going to override approvals and merge it.

@pendo324 pendo324 merged commit b094751 into main Oct 30, 2023
13 checks passed
@pendo324 pendo324 deleted the create-pull-request/patch branch October 30, 2023 21:40
pendo324 added a commit that referenced this pull request Oct 31, 2023
Issue #, if available: N/A

It's been a year since Finch was originally released as a pre-1.0 (i.e.
"unstable") project. Since then, the project has made a number of
improvements to usability, compatibility, and feature-completeness. In
addition to the more visible changes, there is also a suite of
benchmarks and comprehensive e2e and unit tests which are executed on
every single PR/commit. Through 13 releases, Finch has only had [one
unanticipated breaking
change](https://github.com/runfinch/finch/releases/tag/v0.3.0), as the
result of a bug with the initial implementation of persistent disks (and
even then, there was a migration path for users that may have been
impacted).

Other changes that would have been breaking (e.g.
#637 (comment)) have
been caught by our e2e tests and reported/fixed upstream (many times
with the fix proposed/implemented by Finch maintainers), instead of
impacting Finch users. Because of all of this work, I believe that Finch
is now ready to operate as stable software.

*Description of changes:*
- Set next release to v1.0.0

*Testing done:*


- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Justin Alvarez <alvajus@amazon.com>
pendo324 pushed a commit that referenced this pull request Nov 1, 2023
🤖 I have created a release *beep* *boop*
---


## [1.0.0](v0.9.0...v1.0.0)
(2023-10-31)


### chore

* update Release-As version to 1.0.0 (not-squashed)
([2c97323](2c97323))


### Bug Fixes

* ecr credential helper hash check
([#668](#668))
([4b1b0a2](4b1b0a2))
* ecr creds helper and credential_process
([#510](#510))
([0525753](0525753))
* improve creds helper UX
([#673](#673))
([bc238cf](bc238cf))
* run SOCI as a systemd service
([#667](#667))
([24fd649](24fd649))
* soci being reset on vm stop/start
([#672](#672))
([9df7d32](9df7d32))


### Build System or External Dependencies

* **deps:** Bump github.com/docker/cli from 24.0.6+incompatible to
24.0.7+incompatible
([#665](#665))
([43a57ff](43a57ff))
* **deps:** Bump github.com/docker/docker from 24.0.6+incompatible to
24.0.7+incompatible
([#666](#666))
([4e06d28](4e06d28))
* **deps:** Bump github.com/lima-vm/lima from 0.17.2 to 0.18.0
([#643](#643))
([f181b89](f181b89))
* **deps:** Bump github.com/onsi/gomega from 1.27.10 to 1.28.0
([#583](#583))
([9d1ad57](9d1ad57))
* **deps:** Bump github.com/runfinch/common-tests from 0.7.6 to 0.7.7
([#609](#609))
([e21ae83](e21ae83))
* **deps:** Bump github.com/runfinch/common-tests from 0.7.7 to 0.7.8
([#617](#617))
([4d942f5](4d942f5))
* **deps:** Bump github.com/shirou/gopsutil/v3 from 3.23.8 to 3.23.9
([#588](#588))
([20385b7](20385b7))
* **deps:** Bump golang.org/x/tools from 0.13.0 to 0.14.0
([#610](#610))
([8938cf3](8938cf3))
* **deps:** Bump google.golang.org/grpc from 1.53.0 to 1.56.3
([#658](#658))
([321487c](321487c))
* **deps:** Bump k8s.io/apimachinery from 0.28.2 to 0.28.3
([#652](#652))
([05f9d53](05f9d53))
* **deps:** Bump submodules and dependencies
([#637](#637))
([b094751](b094751))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants