Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve creds helper UX #673

Merged
merged 7 commits into from
Oct 31, 2023
Merged

fix: improve creds helper UX #673

merged 7 commits into from
Oct 31, 2023

Commits on Oct 31, 2023

  1. fix: also get aws creds on run since it may pull 

    Signed-off-by: Justin Alvarez <alvajus@amazon.com>
    @pendo324
    pendo324 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    f9b7788 View commit details
    Browse the repository at this point in the history

  2. fix: better UX when config.json exists but isn't set to use credentia… 

    …l helper

Signed-off-by: Justin Alvarez <alvajus@amazon.com>
    @pendo324
    pendo324 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    586a7cf View commit details
    Browse the repository at this point in the history

  3. update tests 

    Signed-off-by: Justin Alvarez <alvajus@amazon.com>
    @pendo324
    pendo324 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    939ba77 View commit details
    Browse the repository at this point in the history

  4. move defer up 

    Signed-off-by: Justin Alvarez <alvajus@amazon.com>
    @pendo324
    pendo324 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    1b93454 View commit details
    Browse the repository at this point in the history

  5. remove parallel testing to reduce flakiness 

    Signed-off-by: Justin Alvarez <alvajus@amazon.com>
    @pendo324
    pendo324 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    6a7e7c1 View commit details
    Browse the repository at this point in the history

  6. address comments 

    Signed-off-by: Justin Alvarez <alvajus@amazon.com>
    @pendo324
    pendo324 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    b160c41 View commit details
    Browse the repository at this point in the history

  7. add additional commands/subcommands that might need creds 

    Signed-off-by: Justin Alvarez <alvajus@amazon.com>
    @pendo324
    pendo324 committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    6aa7326 View commit details
    Browse the repository at this point in the history