Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update a link for the struct link with a full list of configura… #714

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

haytok
Copy link
Member

@haytok haytok commented Dec 4, 2023

…tion options for ${HOME}/.finch/finch.yaml

At this time, the following "the struct here" link in README.md was not updated.

For a full list of configuration options, check the struct here.

Therefore, this commit fixes the "the struct here" link to link the updated struct code.

Issue #, if available: N/A

Description of changes: Detail are described in the commit message.

Testing done: N/A

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…tion options for ${HOME}/.finch/finch.yaml

At this time, the following "the struct here" link in README.md was
misplaced.

  ```
  For a full list of configuration options, check the struct here.
  ```

Therefore, this commit fixes the "the struct here" link to link the
correct struct code.

Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
README.md Outdated Show resolved Hide resolved
…tion options for ${HOME}/.finch/finch.yaml

Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
@haytok
Copy link
Member Author

haytok commented Dec 17, 2023

Hi, @vsiravar

Thanks for comments !!!
I have fixed, so could you please review when you have time ?

@haytok haytok requested a review from vsiravar December 17, 2023 16:17
@vsiravar vsiravar merged commit 762edda into runfinch:main Dec 19, 2023
12 checks passed
@haytok haytok deleted the fix-a-link-in-README branch December 20, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants