ci(refactor): split build-and-test-pkg for better reuse #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
|
Release action run test. It gets past the previously failing step (Install build dependencies) |
Shubhranshu153
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
While I was fixing the macOS pkg build error on macOS 11 (due to
yqfrom brew not building properly), I noticed that most of the file was repeated (due to different archs being built/tested as different jobs) which caused it to be pretty unnecessarily unwieldy. This was the case for both the build and the test workflow jobs.I initially thought I could combine them using matrices, but then we lose the ability to run the test jobs as soon as each respective build completes (with a matrix, it would have to wait until both builds complete, which isn't even guaranteed). There were other complications that made matrices hard, like the fact that we only want to build once per arch, but we want to test on several other arch/version combinations.
Instead, I was able to split the workflows into reusable/composite workflows, so that only the inputs vary, and the script is mostly the same.
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.