Re-enable runkit_import with very limited feature support (doesn't support changing properties, even for new classes) #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TysonAndre
force-pushed
the
work-on-runkit_import
branch
from
a1cbd32
to
c3bbcbf
Compare
TODO: tests/runkit_add_old_style_ctor_by_importing.inc segfaults Work on getting runkit_import.c to compile, add runkit_import to functions declared by runkit
FIXME this doesn't copy the properties yet. Just the methods.
The ALIAS is an alias from an internal (C) function to a user-defined PHP function. This should assert the inside is a ZEND_USER_FUNCTION.
TysonAndre
force-pushed
the
work-on-runkit_import
branch
from
f492569
to
94346fe
Compare
TysonAndre
changed the title
TysonAndre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #73
Property manipulation isn't supported for runkit_import (Code hasn't been fully ported to php 7 yet, and would crash if it were requested)
Method manipulation and function manipulation should work.
Constant manipulation works, but has the same limitations as runkit_constant_add/redefine/remove in this fork, due to aggressive inlining by the PHP compiler.