Fix Development mode #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes unresolvable jobs when
DOTNET_ENVIRONMENTis set toDevelopment(Environment.IsDevelopment = true). This was due to theHost.CreateDefaultBuildersettingServiceProviderOptions.ValidateOnBuild = Environment.IsDevelopmentwhich then caused theServiceProviderto create an instance of each job registered (all jobs in theJobCache).This fix no longer adds all jobs in the
JobCacheto the service collection and changesServiceExtensions.AddConfigintoAddJobwhich adds the job and config that is being run, therefore passing the service provider validation with all of it's dependencies being present.