Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependOnAssemble does not work with Fulladle #299

Open
kozaxinan opened this issue May 12, 2022 · 0 comments
Open

dependOnAssemble does not work with Fulladle #299

kozaxinan opened this issue May 12, 2022 · 0 comments

Comments

@kozaxinan
Copy link
Contributor

kozaxinan commented May 12, 2022

Using dependOnAssemble with Fulladle tries to find TestedExtension in root project. TestedExtension is only part of Android libraries and application. Fulladle should ignore root module when dependOnAssemble is set to true.

* What went wrong:
Could not determine the dependencies of task ':runFlank'.
> Could not create task ':execFlank'.
   > Could not find TestedExtension in logistics-rider-app-android
Caused by: java.lang.IllegalArgumentException: Could not find TestedExtension in logistics-rider-app-android
        at com.osacky.flank.gradle.FladlePluginDelegate$createTasksForConfig$3.execute(FladlePluginDelegate.kt:125)
        at com.osacky.flank.gradle.FladlePluginDelegate$createTasksForConfig$3.execute(FladlePluginDelegate.kt:16)

Fladle 0.17.3

I checked the code and I thought of changing the logic of get method to find for TestedExtension to make it nullable and handle null case. If you guide me desired solution, I can open PR.

ivanalvarado added a commit to ivanalvarado/fladle that referenced this issue Mar 7, 2023
ivanalvarado added a commit to ivanalvarado/fladle that referenced this issue Mar 7, 2023
ivanalvarado added a commit to ivanalvarado/fladle that referenced this issue Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant