Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Do I have to set serviceAccountCredentials? #55

Closed
tir38 opened this issue May 24, 2019 · 2 comments · Fixed by #58
Closed

Question: Do I have to set serviceAccountCredentials? #55

tir38 opened this issue May 24, 2019 · 2 comments · Fixed by #58

Comments

@tir38
Copy link

tir38 commented May 24, 2019

On Flank docs I see that I can set service account credentials locally and for CI using some env vars https://github.com/TestArmada/flank#authenticate-with-a-service-account

If I'm using Fladle can I do this instead of supplying serviceAccountCredentials("${project.file(....) in build.gradle?
@tir38 tir38 changed the title Question: Do I have to set serviceAccountCredentials? Question: Do I have to set serviceAccountCredentials? May 24, 2019
@runningcode
Copy link
Owner

I don't think it is currently supported. I think fladle fails fast if there are no service account credentials in the fladle extension in gradle.
But please try it out and let me know how if it works for your use case. If it doesn't work, let me know how it fails and we can probably fix it!

runningcode added a commit that referenced this issue Jun 4, 2019
@runningcode
Allow serviceAccountCredentials to be set using environment variables.
e93b219 
This means that the project id must be set beforehand.

Fixes #55
@runningcode runningcode mentioned this issue Jun 4, 2019
Merged
runningcode added a commit that referenced this issue Jun 5, 2019
@runningcode
Allow serviceAccountCredentials to be set using environment variables. (
68f6d78 
#58)

This means that the project id must be set beforehand.

Fixes #55
@runningcode
Copy link
Owner

0.6.3 has been released with a fix, let me know if it solves this issue. Note, you must set the project id if the serviceAccountCredentials are not set using the fladle extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow serviceAccountCredentials to be set using environment variables. runningcode/fladle
2 participants
@runningcode @tir38