Treat app and library modules the same in Fulladle #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
July 8, 2021 12:40
runningcode
reviewed
Jul 19, 2021
fladle-plugin/src/main/java/com/osacky/flank/gradle/FulladlePlugin.kt
Outdated
Show resolved
Hide resolved
fladle-plugin/src/main/java/com/osacky/flank/gradle/FulladlePlugin.kt
Outdated
Show resolved
Hide resolved
...le-plugin/src/test/java/com/osacky/flank/gradle/integration/FulladlePluginIntegrationTest.kt
Outdated
Show resolved
Hide resolved
...le-plugin/src/test/java/com/osacky/flank/gradle/integration/FulladlePluginIntegrationTest.kt
Show resolved
Hide resolved
added 3 commits
July 19, 2021 12:41
runningcode
reviewed
Jul 20, 2021
fladle-plugin/src/main/java/com/osacky/flank/gradle/FulladlePlugin.kt
Outdated
Show resolved
Hide resolved
runningcode
approved these changes
Jul 20, 2021
There was a problem hiding this comment.
Look good aside from what appears to me like duplicated code. Once that is addressed I will merge.
Please add some documentation either in this PR or in a follow up. Especially what the expected behavior is that you explained to me in slack.
Please also add this to the release notes in this PR or in a follow up.
added 2 commits
July 20, 2021 15:07
runningcode
reviewed
Jul 21, 2021
|
Buildscan url for run 1053338057 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the methods used to configure app and library modules in Fulladle plugin.
One major problem it solves is handling library modules as root-level app/test APKs (in case there are no app modules, or all app modules are disabled).
Root-level flank app/test apks are both required, and since libraries don't produce app APKs, we first try to set app modules as root level APKs. If none of the app modules are enabled (or if they have no tests), we then try to set libraries as the root-level app. Libraries need to explicitly set
debugApkin theirfulladleModuleConfigblock for the APK to be consumed.