Do not override root level configs with empty properties #271
Conversation
| @@ -290,7 +300,7 @@ class FulladlePluginIntegrationTest { | |||
| test: [0-9a-zA-Z\/_]*/android-project2/build/outputs/apk/androidTest/debug/android-project2-debug-androidTest.apk | |||
| max-test-shards: 5 | |||
| environment-variables: | |||
| "clearPackageData": "true" | |||
| "clearPackageData": "false" | |||
There was a problem hiding this comment.
A question. " usage in here looks wrong. Shouldnt be it just clearPagkageData: false
There was a problem hiding this comment.
I think you are right. Maybe these integration tests aren't working properly since this other PR has written it the other way: https://github.com/runningcode/fladle/pull/266/files#diff-8c950a3cebeff2c0a82c58117c197724232bb55f3341881c5715c27701437e90R117
There was a problem hiding this comment.
What is the actual flank.yml file look like?
There was a problem hiding this comment.
Integrations test are bit confusing. It might make sense to split cases and test case by case. I will try to find out actual flank.yml and check removing ""
|
I think this fixes the same issue as #266 . I like this solution more since it doesn't involve setting the convention to null. |
|
I'm going to merge this for now. The |
|
Buildscan url for run 1245611465 |
Fixes #270
Documentation for using different environment variables per test apk
https://flank.github.io/flank/using_different_environment_variables_in_different_matrices/
Disclamer; I didnt build local snapshot version and I didnt try final result. But I will.