You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds NoStrict and NoStrictData to all modules defining data types for logging (in Kore.Log.*), to avoid constructing log data needlessly.
Estimate:
Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.
Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Did a quick and dirty heap profiling on one or two kevm-bug proofs and there are definitely fewer calls to some functions in Kore.Log due to added laziness without any significant uptick in memory usage, which the github bot also seems to confirm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3087
Scope:
Adds
NoStrict
andNoStrictData
to all modules defining data types for logging (inKore.Log.*
), to avoid constructing log data needlessly.Estimate:
Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.