-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new hook names for crypto hooks #1216
Conversation
Have these hooks been added to the LLVM backend? Are we planning on incorporating the hooks from blockchain-k-plugin directly into the LLVM backend? |
No, these hooks are not part of the llvm backend because that would involve making developers install obscure Bitcoin and cryptography libraries in order to build the k frontend. It's not an issue with java and haskell because their package managers pull in the right libraries automatically. |
Ah sorry, I misread, forgot that this is only for the Java backend. Approving. |
Though I guess someone who needs this should approve as well. |
EDIT: TL;DR version --- I vote we change Since we are changing hook names anyway, I propose the LLVM backend migrates from the name hash function name + digest size hash function name + (separator when hash name ends with number) + digest size |
As far as I can tell, the build failed because github was experiencing problems. I restarted it. |
@ttuegel @sskeirik FYI
This is done in order to separate the crypto hooks out based on which native library they depend on in the llvm backend, in order to simplify the build process for new semantics. The old hooks will remain valid for the time being for backwards-compatibility.