Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline rearrange #3980

Merged
merged 6 commits into from Feb 13, 2024
Merged

Pipeline rearrange #3980

merged 6 commits into from Feb 13, 2024

Conversation

gtrepta
Copy link
Contributor

@gtrepta gtrepta commented Feb 12, 2024

#3973

This factors a few compiler pipeline stages out from between a pair of duplicate stages. If we're able to eliminate the duplicate stages, this change will help narrow down what changes need to be made to do that.

@Baltoli Baltoli marked this pull request as ready for review February 13, 2024 16:59
@ehildenb
Copy link
Member

ehildenb commented Feb 13, 2024

@gtrepta was this tested downstream with KEVM and KMIR and KWasm? Feel free to add back automerge if so!

@gtrepta
Copy link
Contributor Author

gtrepta commented Feb 13, 2024

@gtrepta was this tested downstream with KEVM and KMIR and KWasm? Feel free to add back automerge if so!

@ehildenb KEVM and KWasm checked out, their definition.kore files with this change were identical to the ones without the change. KMIR's build system is using some temporary folders which cause different location attributes in the emitted kore, making it harder to determine whether or not they're semantically identical. I'll see if I can isolate the stage of the build that just calls kompile and then make the comparison from there.

@ehildenb
Copy link
Member

@gtrepta KEVM and KWasm should be good enough I guess, though it would be good to get in the habit of also checking KMIR for stability. I guess adding the relevant files upstreamed here (with kompile -E like we've done with KEVM/KWasm) can be done in a follow-up PR to make later changes easier.

@rv-jenkins rv-jenkins merged commit 179bc53 into develop Feb 13, 2024
8 checks passed
@rv-jenkins rv-jenkins deleted the pipeline-rearrange branch February 13, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants