Fix version parsing script #4095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baltoli
commented
Mar 13, 2024
| @@ -36,7 +36,7 @@ else | |||
| setarch | |||
| JAVA=$NG | |||
| else | |||
| version=$("$_java" -version 2>&1) | |||
| version=$("$_java" --version) | |||
There was a problem hiding this comment.
For some reason, java --version prints to stdout and -version to stderr. The two-dash version appears to be the more consistent format as well.
Baltoli
commented
Mar 13, 2024
|
|
||
| # The Java version information we're parsing here looks something like this: | ||
| # | ||
| # openjdk 21.0.2 2024-01-16 |
There was a problem hiding this comment.
Previously, java -version would - for some implementations - produce something like:
openjdk version "21.0.2" 2024-01-16
on the first line.
This was
linked to
issues
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies some minor cleanup to the
checkJavascript's parsing ofjava --versionoutput. The new code will produce a correct error message for Java >= 11, and better handles slightly different formats of version data produced by different JVM implementations.Fixes #4059
Fixes #4061