Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install-build-deps script #4505

Conversation

0cjs
Copy link
Contributor

@0cjs 0cjs commented Jul 5, 2024

Add an install-build-deps script to replace the manual commands in the README. See commit message(s) for details.

WARNING: This commit is based on the commit in #4054; if you merge this it will merge that one too. (The script includes the libunwind-dev package added in that commit.)

You'll probably want to do a quick check that this works on MacOS and update the commit message appropriately.

@0cjs 0cjs force-pushed the dev/cjs/24g05/install-build-deps-script branch from c6ae4a0 to 58842df Compare July 5, 2024 16:59
@0cjs 0cjs force-pushed the dev/cjs/24g05/install-build-deps-script branch 2 times, most recently from 7e2073a to e5ea4e4 Compare July 17, 2024 13:03
@0cjs
Copy link
Contributor Author

0cjs commented Jul 17, 2024

This has now been tested on a Mac and fixes applied to make that work properly. (I didn't look closely enough at the Mac code when I was testing on Debian.) It's also been rebased on to the top of the current main.

@Baltoli Baltoli changed the base branch from master to develop July 20, 2024 13:19
@Baltoli
Copy link
Collaborator

Baltoli commented Jul 20, 2024

@0cjs you will need to rebase this PR on the develop branch and cut out all the "Set version..." commits; once you've done so CI should run properly for you and we can look at getting this merged. Thanks for the contribution!

Copy link
Collaborator

@Baltoli Baltoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but PR needs to be rebased.

This removes the `apt-get install` and `brew install` instructions and
lists of packages (and, for Debian, Haskell Stack as well) from the
README.md file and moves them to a script that will determine which set to
install and do the install. (This can easily be expanded to support other
systems if necessary.) The improvement to developer convenience should be
obvious.

This also tweaks the bits of Markdown we touched to move the referenced
URLs to the end of the file, to make it easier to read the plaintext.

The script has been tested on Debian 12, Bash 3.2.48(3) on a Debian system
and on MacOS (using some version of Bash 3).
@0cjs 0cjs force-pushed the dev/cjs/24g05/install-build-deps-script branch from a66e079 to a566905 Compare July 23, 2024 12:19
@0cjs
Copy link
Contributor Author

0cjs commented Jul 23, 2024

It's now rebased.

BTW, I see no harm in you guys just doing this directly (since you're already changing the tracking ("base") branch of the developer's branch anyway. That would help speed things up. (It's reasonable to bail on it if there's any issues doing that, of course, and ask the original developer to fix conflicts or whatever.)

@rv-jenkins rv-jenkins merged commit ff1da0a into runtimeverification:develop Jul 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants