-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding --proof-hint
flag to PyK KRun
#4532
Open
Robertorosmaninho
wants to merge
9
commits into
develop
Choose a base branch
from
pi2/proof-hint-flag-to-pyk-krun
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
55ee1b3
Adding `--proof-hint` flag to PyK KRun
Robertorosmaninho efcc3ed
Formatting code
Robertorosmaninho 93ca0c0
Update pyk/src/pyk/ktool/krun.py
Robertorosmaninho ffb2d54
Adding `proof_hint` to krun unit-test
Robertorosmaninho 86c8214
Adding `pipe_stdout` flag False when `proof_hint` is passed
Robertorosmaninho 977bcb6
Formatting
Robertorosmaninho b5a445e
Deleting `write` call as the hints we're already printed by `subprocess`
Robertorosmaninho 832c329
Merge branch 'develop' into pi2/proof-hint-flag-to-pyk-krun
Robertorosmaninho 43d618d
Modfiying conditions with proof_hint
Robertorosmaninho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,7 @@ | |
('search_final', False), | ||
('no_pattern', False), | ||
('debugger', False), | ||
('proof_hint', False), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add an integration test for checking the proof hints output for some execution. |
||
] | ||
) | ||
|
||
|
@@ -40,6 +41,7 @@ | |
'search_final': (True, ['--search-final']), | ||
'no_pattern': (True, ['--no-pattern']), | ||
'debugger': (True, ['--debugger']), | ||
'proof_hint': (True, ['--proof-hint']), | ||
} | ||
|
||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, this approach won't work: under the hood it leads to a call like
which will raise an exception:
This is because
stdout=subprocess.PIPE
, soCompletedProcess.stdout
will be populated.text=True
, so the function will try to decode the bytes output to produceCompletedProcess.stdout
.You drop any of these arguments and it'll work.
Please add a test to reproduce this issue.
Workarounds:
_build_arg_list
and callsubprocess.run
directly.encoding
through tosubprocess.run
(standard encodings).pipe_stdout=False
torun_process
, so that you havestdout=None
insubprocess.run
.run_process
(and it's newer version,run_process_2
) to accepttext=False
, but that's not straightforward.I'd prefer a solution that won't prevent us from dropping
run_process
in favor ofrun_process_2
in the future, i.e. (1) or (2).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right! I dropped
text=True
locally and forgot to commit this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About your workarounds:
run_process
?pipe_stdout = not prof_hint
.If you don't mind, I would prefer to stick to option 3 to unblock Pi2 folks, and when we need to drop
run_process
in favor ofrun_process_2
, we can sit together again to brainstorm a way to make it compatible with proof hints.