This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Fix circular import #925
Merged
Fix circular import #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwatson22
commented
Feb 27, 2024
This PR introduces the following changes: * Refactors `remove_useless_constraints` to take a list of constraints rather than a `CTerm`, and reimplements the original version as a method of `CTerm`. * Use the new `remove_useless_constraints` to restrict the constraints used to build a refutation proof to only those that have a dependency on the most recent branch. * Add a test that the refutation proof omits independent constraints. --------- Co-authored-by: devops <devops@runtimeverification.com>
ehildenb
approved these changes
Feb 27, 2024
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
#915 introduced a circular import crash which is triggered when executing `pyk rpc-kast` `rpc.py > kprove.py > cterm > symbolic.py > rpc.py` Moves `KoreExecLogFormat` to `kore/rpc.py` --------- Co-authored-by: devops <devops@runtimeverification.com> Co-authored-by: lucasmt <36549752+lucasmt@users.noreply.github.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
#915 introduced a circular import crash which is triggered when executing `pyk rpc-kast` `rpc.py > kprove.py > cterm > symbolic.py > rpc.py` Moves `KoreExecLogFormat` to `kore/rpc.py` --------- Co-authored-by: devops <devops@runtimeverification.com> Co-authored-by: lucasmt <36549752+lucasmt@users.noreply.github.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
#915 introduced a circular import crash which is triggered when executing `pyk rpc-kast` `rpc.py > kprove.py > cterm > symbolic.py > rpc.py` Moves `KoreExecLogFormat` to `kore/rpc.py` --------- Co-authored-by: devops <devops@runtimeverification.com> Co-authored-by: lucasmt <36549752+lucasmt@users.noreply.github.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
#915 introduced a circular import crash which is triggered when executing `pyk rpc-kast` `rpc.py > kprove.py > cterm > symbolic.py > rpc.py` Moves `KoreExecLogFormat` to `kore/rpc.py` --------- Co-authored-by: devops <devops@runtimeverification.com> Co-authored-by: lucasmt <36549752+lucasmt@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#915 introduced a circular import crash which is triggered when executing
pyk rpc-kastrpc.py > kprove.py > cterm > symbolic.py > rpc.pyMoves
KoreExecLogFormattokore/rpc.py