This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Options improvements retry #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fication/pyk into noah/default-options
…fication/pyk into noah/default-options
Co-authored-by: Tamás Tóth <tothtamas28@users.noreply.github.com>
ehildenb
approved these changes
Mar 11, 2024
nwatson22
added a commit
that referenced
this pull request
Mar 11, 2024
This reverts commit dbdd0c1.
ehildenb
pushed a commit
that referenced
this pull request
Mar 11, 2024
rv-jenkins
pushed a commit
that referenced
this pull request
Mar 14, 2024
Adds `Options` class hierarchy which stores all the parameters associated with command line options for pyk, and is extendable by downstream projects. This is a part of the changes pulled out from #967. - Adds `Options` which automatically populates its fields from a prepared `dict` from the parsed command line args and sets default values when the values are missing - Adds `LoggingOptions`, etc., which are groups of options that can be inherited by commands - Adds `ProveOptions`, etc. which are directly associated with particular pyk commands but otherwise behave the same - `exec_*` functions now take the corresponding `*Options` type instead of generic `Namespace` - Defaults are no longer set at the argparse level since they are now set in `Options` constructor. --------- Co-authored-by: devops <devops@runtimeverification.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
Changes from: - runtimeverification/pyk#916 - runtimeverification/pyk#955 --------- Co-authored-by: devops <devops@runtimeverification.com> Co-authored-by: Tamás Tóth <tothtamas28@users.noreply.github.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
Changes from: - runtimeverification/pyk#916 - runtimeverification/pyk#955 --------- Co-authored-by: devops <devops@runtimeverification.com> Co-authored-by: Tamás Tóth <tothtamas28@users.noreply.github.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
Changes from: - runtimeverification/pyk#916 - runtimeverification/pyk#955 --------- Co-authored-by: devops <devops@runtimeverification.com> Co-authored-by: Tamás Tóth <tothtamas28@users.noreply.github.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
Changes from: - runtimeverification/pyk#916 - runtimeverification/pyk#955 --------- Co-authored-by: devops <devops@runtimeverification.com> Co-authored-by: Tamás Tóth <tothtamas28@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from: