Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deposit: further improvement of specs #320

Merged
merged 8 commits into from Mar 25, 2020
Merged

Deposit: further improvement of specs #320

merged 8 commits into from Mar 25, 2020

Conversation

daejunpark
Copy link
Contributor

@daejunpark daejunpark commented Mar 20, 2020 •
edited

This further improves the specs.

  • Now the init spec considers arbitrary accidental and/or malicious calldata garbage for security.
  • The loop invariant regarding the loop index for both get_deposit_root and deposit is clarified.
  • The gas/memory cost description is simplified to avoid duplication in the ini file.
  • The unnecessary cells are omitted in the specification.
  • And, some minor reorgs.

@daejunpark
Copy link
Contributor Author

Ignore the first three commits, which will be rebased once #318 and #319 are merged.

suhabe
suhabe approved these changes Mar 23, 2020
View reviewed changes
Copy link

@suhabe suhabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daejunpark daejunpark merged commit c12cff9 into master Mar 25, 2020
@daejunpark daejunpark deleted the deposit3 branch March 25, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suhabe suhabe suhabe approved these changes

@MrChico MrChico Awaiting requested review from MrChico

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daejunpark @suhabe