-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APP] MQTTX #3480
[APP] MQTTX #3480
Conversation
WalkthroughThe recent updates to MQTTX bring improvements to configuration, deployment, and descriptive content, enhancing the MQTTX Web MQTT browser client's usability and accessibility for users. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
apps/mqttx/metadata/logo.jpg
is excluded by!**/*.jpg
Files selected for processing (3)
- apps/mqttx/config.json (1 hunks)
- apps/mqttx/docker-compose.yml (1 hunks)
- apps/mqttx/metadata/description.md (1 hunks)
Files skipped from review due to trivial changes (2)
- apps/mqttx/config.json
- apps/mqttx/docker-compose.yml
Additional Context Used
LanguageTool (7)
apps/mqttx/metadata/description.md (7)
Near line 3: Unpaired symbol: ‘[’ seems to be missing
Context: ...upports formatting MQTT payload. MQTTX simplifies test oper...
Near line 5: Unpaired symbol: ‘[’ seems to be missing
Context: ...s other MQTT protocol features. > [MQTT](https://www.emqx.com/en/blog/the-easies...
Near line 5: Did you mean the noun “publishing”?
Context: ...nds for MQ Telemetry Transport. It is a publish/subscribe, extremely simple and lightwe...
Near line 5: As an alternative to the over-used intensifier ‘extremely’, consider replacing this phrase.
Context: ...y Transport. It is a publish/subscribe, extremely simple and lightweight messaging protocol, des...
Near line 29: Consider adding a hyphen.
Context: ...ured, click theConnect
button in the upper right corner to create a connection and conne...
Near line 85: Unpaired symbol: ‘’ seems to be missing
Context: ...lectron - Vue + [Element](https:/...
Near line 85: Unpaired symbol: ‘]’ seems to be missing
Context: ...njs.org/) - Vue + Element - [Ty...
Additional comments not posted (8)
apps/mqttx/metadata/description.md (8)
1-3
: Introduction section looks clear and concise.
9-9
: Preview image link is correctly formatted.
11-31
: Usage instructions are clear and well-structured.
35-41
: Community involvement links are correctly formatted and appropriate.
44-61
: Development setup commands are correctly formatted and standard.
79-80
: Contributing guide link is correctly formatted and relevant.
82-89
: Technology stack links are correctly formatted.
91-99
: Resource links are relevant and correctly formatted.
The Google Doc listing ports (https://docs.google.com/spreadsheets/d/13U8MNCOiQjR4XohNCl9-CrmqS8_CA-oFEy3wrnJBJks/edit?usp=sharing) was outdated. The new table view in the Tipi Appstore helped me find the port clash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Hello @Wraithers thank you for your PR. I made some changes and merged #3715 instead. Because you merged |
The Cedalo Management Center included in the Eclipse Mosquitto app doesn't seem to come with a publish message option to debug MQTT topics etc., so I'm making this pull request so that MQTTX can be used for that purpose. Worked well for me over the last few months 😊
If you think this should be merged with Eclipse Mosquitto along with/to replace Cedalo Management Center, I'm happy to revise the pull request 👍
Summary by CodeRabbit
New Features
Documentation