feat: support arbitrary length unions #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to separate out "RuntypeBase" which only includes the actual validation methods from "Runtype" which includes all the helper methods. This is because internally we frequently treat Runtype as "covariant" i.e. if I was expecting a `Runtype<string>` it's ok to give me a `Runtype<'hello world'>`. TypeScript historically hasn't cared that much about variance, but over time it is getting strickter and the helper methods are often invariant. BREAKING CHANGE: the various `Union2`, `Union3`, ... types have all been replaced with a single `Union` type that takes a tuple of Runtype validators.
I will create my own example at some point in the future, but for now the README will do
|
What is needed to get this merged? |
|
Please don't include changes that are only relevant to your fork release. This package is not |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to separate out "RuntypeBase" which only includes the actual validation methods from "Runtype" which includes all the helper methods. This is because internally we frequently treat Runtype as "covariant" i.e. if I was expecting a
Runtype<string>it's ok to give me aRuntype<'hello world'>. TypeScript historically hasn't cared that much about variance, but over time it is getting strickter and the helper methods are often invariant.BREAKING CHANGE: the various
Union2,Union3, ... types have all been replaced with a singleUniontype that takes a tuple of Runtype validators.