Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat missing fields as undefined #61

Merged
merged 1 commit into from Jul 29, 2018
Merged

Treat missing fields as undefined #61

merged 1 commit into from Jul 29, 2018

Conversation

chris-pardy
Copy link
Contributor

  • Add test to ensure a missing required field is an error
  • Add test to ensure undefined is allowed for undefined fields
  • Add test to ensure that missing fields are treated as undefined.

Resolves #60

@chris-pardy chris-pardy mentioned this pull request Jul 26, 2018
Closed
Treat missing fields as undefined \n* Add test to ensure a missing re…
0524629 
…quired field is an error* Add test to ensure undefined is allowed for undefined fields* Add test to ensure that missing fields are treated as undefined.
@coveralls
Copy link
Collaborator

Coverage Status

Coverage decreased (-0.003%) to 99.476% when pulling 0524629 on chris-pardy:allow-missing-property into 406d92b on pelotom:master.

pelotom
pelotom approved these changes Jul 29, 2018
View reviewed changes
Copy link
Collaborator

@pelotom pelotom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@pelotom pelotom merged commit e1e5590 into runtypes:master Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pelotom pelotom pelotom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chris-pardy @coveralls @pelotom