fix: make sure TestMetrics doesn't remove state
#164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklaslong
reviewed
Sep 6, 2022
niklaslong
reviewed
Sep 6, 2022
niklaslong
approved these changes
Sep 6, 2022
zeapoz
pushed a commit
to zeapoz/zcash
that referenced
this pull request
Apr 13, 2023
fix: make sure `TestMetrics` doesn't remove state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of issues with our current
DebuggingRecorderimplementation. We now take a snapshot separately from querying the values. This fixes an issue inresistance::stress_testwhere we had two sequentialconstruct_histogramqueries; the initial one would erase state after its use, leading to nil data in our subsequent query. Now that state is handled separately, we also get a minor boost to performance.