Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve zcash ci #169

Merged
merged 14 commits into from Oct 10, 2022
Merged

Improve zcash ci #169

merged 14 commits into from Oct 10, 2022

Conversation

zeapoz
Copy link
Contributor

@zeapoz zeapoz commented Oct 6, 2022

This PR improves the GitHub Actions test spinner. It now is able to spin up a node instance and run it through the ziggurat suite, logging results under results/$TIMESTAMP.jsonl. Also introduces a separate workflow for running with a stable/nightly compiler.

Copy link
Member

@aphelionz aphelionz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/zcashd.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@ljedrz ljedrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a question regarding the toolchain use; other than that, I'd squash some of the commits, as the history is messy right now

@muzam1l
Copy link
Member

muzam1l commented Oct 6, 2022

Maybe also have 'latest' tagged file, in addition to timestamped ones. I suppose accessing file list is via GitHub api, while accessing known file is open, thus avoiding complexity for now?

@muzam1l
Copy link
Member

muzam1l commented Oct 7, 2022

Is this supposed to produce crawler data as well or that's gonna be another pr?

@zeapoz
Copy link
Contributor Author

zeapoz commented Oct 7, 2022

Yeah, I'd say that is better suited as a follow-up PR

@zeapoz zeapoz requested review from ljedrz and aphelionz and removed request for ljedrz and aphelionz October 7, 2022 09:27
Copy link
Collaborator

@ljedrz ljedrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@aphelionz aphelionz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the one comment

zeapoz and others added 2 commits October 7, 2022 10:31
Co-authored-by: Mark Robert Henderson <henderson.mark@gmail.com>
@aphelionz aphelionz merged commit cd5f11c into runziggurat:zcash-ci Oct 10, 2022
@zeapoz zeapoz deleted the zcash-ci branch October 10, 2022 12:06
zeapoz pushed a commit to zeapoz/zcash that referenced this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants