New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve zcash ci #169
Improve zcash ci #169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a question regarding the toolchain use; other than that, I'd squash some of the commits, as the history is messy right now
Maybe also have 'latest' tagged file, in addition to timestamped ones. I suppose accessing file list is via GitHub api, while accessing known file is open, thus avoiding complexity for now? |
Is this supposed to produce crawler data as well or that's gonna be another pr? |
Yeah, I'd say that is better suited as a follow-up PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending the one comment
Co-authored-by: Mark Robert Henderson <henderson.mark@gmail.com>
Improve zcash ci
This PR improves the GitHub Actions test spinner. It now is able to spin up a node instance and run it through the ziggurat suite, logging results under
results/$TIMESTAMP.jsonl
. Also introduces a separate workflow for running with a stable/nightly compiler.