Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add search bar in sidebar #112

Closed
rupali-codes opened this issue Jan 28, 2023 · 8 comments
Closed

[Feature] Add search bar in sidebar #112

rupali-codes opened this issue Jan 28, 2023 · 8 comments
Assignees
Labels
goal: new-feature New feature or request in progress For large issues

Comments

@rupali-codes
Copy link
Owner

Description

The more elements we are adding in sidebar, the more it's getting difficult to search between components.

Specific requirements

  1. Add a input bar (search bar) at top of sidebar
  2. Background color should be transparent
  3. Should start searching as user starts typing
  4. Should render search results in sidebar itself

Screenshots

No response

Additional Information

No response

@rupali-codes rupali-codes added goal: new-feature New feature or request frontend up for grabs this issue open for the taking labels Jan 28, 2023
@ConradQQ
Copy link
Contributor

Happy to handle this one if it's still available.

@rupali-codes
Copy link
Owner Author

@ConradQQ thank you for being interested, but you're already working on 2 issues, kindly fix them, and if this issue doesn't get assigned to anybody, then we will definitely assign it to you.

@rupali-codes
Copy link
Owner Author

@ConradQQ you PRs were merged, would you like to work on this?

@ConradQQ
Copy link
Contributor

For sure! I'd be happy to work on this.

@rupali-codes
Copy link
Owner Author

@ConradQQ Thank you, assigning to you :)

@rupali-codes
Copy link
Owner Author

@ConradQQ any updates?

@fracergu
Copy link
Contributor

fracergu commented Feb 4, 2023

Hi!, I just opened a PR that solves this issue 😀

I have also separated the search functionality into two hooks, one general and one specific, to be able to reuse it in the future if necessary.

#133

@rupali-codes rupali-codes assigned fracergu and unassigned ConradQQ Feb 4, 2023
@rupali-codes
Copy link
Owner Author

Hi!, I just opened a PR that solves this issue 😀

I have also separated the search functionality into two hooks, one general and one specific, to be able to reuse it in the future if necessary.

#133

yeah, thank you so much, i have suggested some changes, please fix them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-feature New feature or request in progress For large issues
Projects
None yet
Development

No branches or pull requests

3 participants