Added search bar for sidebar. #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created two search hooks:
- useSearch: Manages search input and allows to use debounced search
- useSidebarSearch: Uses previous hook to get data from database and
filter it if needed
closes #114
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rupali-codes
requested changes
Feb 4, 2023
There was a problem hiding this comment.
Thank for contributing, it looks great, but there's some small issues needs to be fixed:
- Searchbar overlapping in small screen i.e It's not responsive
It's should be in the sidebar
- Color contrast
on-focusis too much, and it does not match with our theme.
Make it eithervioletorgray
- Background color should be as same as sidebar background color
applications theme. Moved Searchbar component inside the menu container to inherit responsiveness
|
Thank you, could you please resolve conflicts? |
rupali-codes
reviewed
Feb 5, 2023
Co-authored-by: Rupali Haldiya <78981177+rupali-codes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created two search hooks:
Closes #114