Change button to link for sidebar elements. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Please create and attach an issue, and follow CONTRIBUTION guidelines. Thank you |
|
Apologies did not realise contributing guidelines have now been added. |
JoshHargreaves
force-pushed
the
jh-feature
branch
from
6ac282c
to
e9820c1
Compare
1 task
|
@JoshHargreaves thanks for quick changes, what's the difference between using and ? |
|
The anchor tag generally represents a link to another page or section within a page whereas the button is more meant to represent an action resulting from a click. The Link tag I have added here is a Next JS element that enables client-side transitions and removes the need for custom routing code at the top of the page. |
|
Got it. Thank You |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56
Changes proposed
Changes the sidebar elements to use instead of A to correctly follow coding guidelines and remove HTML warnings.