Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar links should be <Link> not button #56

Closed
1 task done
JoshHargreaves opened this issue Jan 19, 2023 · 1 comment · Fixed by #54
Closed
1 task done

Sidebar links should be <Link> not button #56

JoshHargreaves opened this issue Jan 19, 2023 · 1 comment · Fixed by #54

Comments

@JoshHargreaves
Copy link
Contributor

Is there any existing issue for this?

  • I have searched the existing issues

Description

Sidebar links are currently generating an HTML warning. We should change these to instead of to follow coding guidelines.

Screenshots

No response

Any additional information?

No response

What browser are you seeing the problem on?

No response
@JoshHargreaves JoshHargreaves mentioned this issue Jan 19, 2023
Merged
@JoshHargreaves
Copy link
Contributor Author

A PR has been created for this : #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change button to link for sidebar elements. JoshHargreaves/LinksHub
1 participant
@JoshHargreaves