Set target_version to set() on the default config #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens whenever running pyls_black on a project that doesn't define a config file (there's an early return). Writing a test for this can get tricky, but I could give it a shot.
Merged
rupert
approved these changes
Mar 26, 2019
|
@fsouza thanks for the quick fix. I've manually tested it in a project without a config file and it seems to have fixed the bug. It's been released in version If you have time to add a proper test, I would be really grateful. Thanks! |
|
@rupert thanks for the quick feedback! I'll look into writing a test tomorrow, I apologize for not including it originally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens whenever running pyls_black on a project that doesn't
define a config file (there's an early return).
Writing a test for this can get tricky, but I could give it a shot.
Follow up from #20.