Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for skip-numeric-underscore-normalization #6

Merged
merged 3 commits into from
Oct 16, 2018

Conversation

dbarrosop
Copy link
Contributor

No description provided.

@pmiddend
Copy link

pmiddend commented Oct 6, 2018

Note that you have a "line too long" error there.

@dbarrosop
Copy link
Contributor Author

where? all the checks are green

@pmiddend
Copy link

pmiddend commented Oct 7, 2018

Maybe I misread the output:

https://circleci.com/gh/rupert/pyls-black/42

@dbarrosop
Copy link
Contributor Author

Oh, that's an old build. Last one is:

https://circleci.com/gh/rupert/pyls-black/47

@wy-z
Copy link

wy-z commented Oct 10, 2018

image

I need this patch.
Thank you for your contribution @dbarrosop

@kodonnell
Copy link

kodonnell commented Oct 11, 2018

@rupert is there a way to get this reviewed (and hence merged)? Also, a new push to pypi?

@rupert rupert self-requested a review October 11, 2018 11:22
@rupert
Copy link
Owner

rupert commented Oct 11, 2018

@dbarrosop thanks for the PR! I will have a look this evening 👍

@Mic92
Copy link

Mic92 commented Oct 11, 2018

Tested successfully.

@Mic92
Copy link

Mic92 commented Oct 11, 2018

it would make sense to also create a release when merging this. I will then update the nixpkgs package accordingly: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/pyls-black/default.nix

@rupert rupert merged commit 2d9ca1a into rupert:master Oct 16, 2018
@rupert rupert mentioned this pull request Oct 16, 2018
@rupert
Copy link
Owner

rupert commented Oct 16, 2018

@dbarrosop thanks again and sorry for the delay - this is released in version 0.3.0.

@rupert rupert mentioned this pull request Oct 16, 2018
@dbarrosop
Copy link
Contributor Author

Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants