Interoperability fail with JSON::XS

[samuelckaufman]

Copied from https://rt.cpan.org/Public/Bug/Display.html?id=92548

use Cpanel::JSON::XS ();

my $boolstring = '{ "is_true" : true }';
my $xs_string;
{
    use JSON::XS ();
    my $json = JSON::XS->new;
    $xs_string = $json->decode( $boolstring );
}

my $json = Cpanel::JSON::XS->new;
$json->encode( $xs_string );
#^ dies: encountered object '1', but neither allow_blessed nor
# convert_blessed settings are enabled

This becomes a problem when trying to use Cpanel::JSON::XS for a drop in
replacement without replacing JSON::XS everywhere.

[rurban]

Thanks for the testcase. The boolean wrapper needs to accept both objects.

sub is_bool($) {
   UNIVERSAL::isa $_[0], "Cpanel::JSON::XS::Boolean"
     or UNIVERSAL::isa $_[0], "JSON::XS::Boolean"
}

But in this case JSON::XS::Boolean fails to accept Cpanel::JSON::XS::Boolean,
which is I am afraid unfixable currently, as Marc Lehmann will not do it.
So it looks like we will have to rename our boolean object back to JSON::XS::Boolean and risc a little CPAN conflict.

I'll check it out.

[rurban]

Fixed in 2.3404:
- fix interop with JSON::XS booleans,
the internal boolean objects are now blessed into JSON::XS::Boolean
#13 and cpan #92548
- t/96_interop.t: added

[samuelckaufman]

great, thanks again

[rurban]

Note that JSON-2.90 and esp. JSON-XS-3.01 broke that again, so I had to fix that with Cpanel-JSON-XS-3.0101