Fixes for JSON_TYPE_INT type when numbers above 2^64-1 are passed #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pali
commented
Aug 22, 2019
pali
commented
- allow to encode numeric values above 2^64 in PV slot
- allow to pass Math::BigInt and Math::BigFloat objects
…t via Math::BigInt/Float Option ->allow_bignum is required for it as big number is parsed via Math::BigInt or Math::BigFloat (based on what grok_number returns) as it cannot be represented in UV type.
…at objects Option ->allow_bignum is required. Without it it is not possible to pass Math::BigInt and Math::BigFloat objects. For converting Math::BigFloat to Math::BigInt should be used $obj->bint method, equivalent of perl's int() function for non-big floats. But this method is not available in older Math::BigFloat versions. Older Math::BigFloat versions have $obj->as_number method which should do same thing as $obj->bint method but in some Math::BigFloat versions it is broken and loose precision, so it cannot be used. So for conversion from Math::BigFloat to Math::BigInt use either $obj->bceil or $obj->bfloor method based on information if $obj is negative or not. This is simulation of rounding and should give us same result as $obj->bint method.
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.