remove overloads before re-adding them to silence warnings #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent warnings from redefining overloads on JSON::PP::Boolean, the code is setting $^W to 0. This has classically worked because overload.pm did not enable or disable warnings. This is not something that should be relied on. Rather than rely on $^W, just remove the overloads we are expecting to overwrite using overload->unimport.
|
Excellent idea! p5p should do the same with their core modules |
|
JSON::PP at least has already integrated this change. I'll probably take a look and see if it applies anywhere else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent warnings from redefining overloads on JSON::PP::Boolean, the code is setting $^W to 0. This has classically worked because overload.pm did not enable or disable warnings. This is not something that should be relied on.
Rather than rely on $^W, just remove the overloads we are expecting to overwrite using overload->unimport.