C: fix #140. reset HvTOTALKEYS also on 5.14 on empty hashes

This new HvTOTALKEYS macro apparently sneeked into 5.14 also
rurban · Oct 30, 2013 · 43902ed · 43902ed
1 parent 74cfffe
commit 43902ed
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/lib/B/C.pm b/lib/B/C.pm
@@ -3935,8 +3935,8 @@ sub B::HV::save {
       $init->add("}");
       $init->split;
     }
-  } elsif ($] >= 5.015) { # empty contents still needs to set keys=0
-    # test 36
+  } elsif ($] >= 5.014) { # empty contents still needs to set keys=0
+    # test 36, 140
     $init->add( "HvTOTALKEYS($sym) = 0;");
     $init->add( "SvREADONLY_on($sym);") if $hv->FLAGS & SVf_READONLY;
   }

diff --git a/t/modules.t b/t/modules.t
@@ -284,6 +284,10 @@ sub is_todo {
   #    MooseX::Types
   #    DateTime
   #)) { return '> 5.15 (unshare_hek)' if $_ eq $module; }}
+  if ($] >= 5.018) { foreach(qw(
+      ExtUtils::ParseXS
+      Module::Build
+    )) { return '>= 5.18' if $_ eq $module; }}
 
   # ---------------------------------------
   if ($Config{useithreads}) {
@@ -321,6 +325,9 @@ sub is_todo {
       Storable
       Sub::Name
     )) { return '5.12.0 with threads' if $_ eq $module; }}
+    if ($] >= 5.018) { foreach(qw(
+      ExtUtils::CBuilder
+    )) { return '>= 5.18 with threads' if $_ eq $module; }}
   } else { #no threads --------------------------------
     # This was related to aelemfast->sv with SPECIAL pads fixed with 033d200
     if ($] > 5.008004 and $] <= 5.008005) { foreach(qw(

diff --git a/t/testc.sh b/t/testc.sh
@@ -537,6 +537,9 @@ fi
 #issue 138
 tests[138]='print map { chr $_ } qw/97 98 99/;'
 result[138]='abc'
+#issue 140
+tests[140]='my %a;print "ok" if !%a;'
+result[140]='ok'
 #issue 30
 tests[230]='sub f1 { my($self) = @_; $self->f2;} sub f2 {} sub new {} print "@ARGV\n";'
 result[230]=''