Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'no jitsize 0' test fails on s390x where JIT is not available #23

Closed
ppisar opened this issue Apr 25, 2017 · 3 comments
Closed

'no jitsize 0' test fails on s390x where JIT is not available #23

ppisar opened this issue Apr 25, 2017 · 3 comments

Comments

@ppisar
Copy link
Contributor

ppisar commented Apr 25, 2017

I noticed that 'no jitsize 0' test fails on s390x platform:

t/capture.t ............... ok
#   Failed test 'no jitsize 0'
#   at t/config.t line 72.
#          got: '155'
#     expected: '0'
# Looks like you failed 1 test of 37.
t/config.t ................ 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/37 subtests

Reading the code, it looks like the XS code simply returns pcre2_pattern_info(..., PCRE2_INFO_JITSIZE, ...) value and that is documented as 0, so it looks like a bug in PCRE2. I will check it and forward it to PCRE2 authors if it's the cause.
@ppisar
Copy link
Contributor Author

ppisar commented Apr 25, 2017

I can reproduce it on x86_64 after passing --disable-jit to PCRE2's ./configure.

@ppisar
Copy link
Contributor Author

ppisar commented Apr 25, 2017

It's a copy-and-paste typo in the PCRE2.xs:612. There should be JITSIZE, not SIZE.

ppisar added a commit to ppisar/re-engine-PCRE2 that referenced this issue Apr 25, 2017
@ppisar
Fix retrieving JIT SIZE
eca9c82 
There was a typo causing jitsize() to return value of non-JIT
compiled pattern. It manifested into 'no jitsize 0' t/config.t
failures on systems where PCRE2 library has disabled JIT. This patch
fixes it.

rurban#23
@ppisar ppisar mentioned this issue Apr 25, 2017
Merged
rurban pushed a commit that referenced this issue Apr 25, 2017
@ppisar @rurban
Fix retrieving JIT SIZE
7061e39 
There was a typo causing jitsize() to return value of non-JIT
compiled pattern. It manifested into 'no jitsize 0' t/config.t
failures on systems where PCRE2 library has disabled JIT. This patch
fixes it.

#23
@rurban
Copy link
Owner

rurban commented May 3, 2017

Fixed with 0.12

@rurban rurban closed this as completed May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rurban @ppisar