Fix return values of String#casecmp
#339
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://bugs.ruby-lang.org/issues/12835
調べられる範囲で調べてみたところ、1.8.6 でも
TypeError
でした。String#+
などでもStringValue
による@raise TypeError
はいちいち書いていないので、返り値だけ変更しています。-1
,0
,1
以外を返すことはなさそうだったので、Integer
もSymbol#casecmp
と同じく-1 | 0 | 1
に変更しました。