Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better tests for RECEIVE #109

Merged
merged 1 commit into from
Jul 23, 2022
Merged

Conversation

phoe
Copy link
Contributor

@phoe phoe commented Jan 24, 2022

Split off from #108

It seems there are some ECL failures on these.

@phoe phoe mentioned this pull request Jan 24, 2022
7 tasks
@phoe
Copy link
Contributor Author

phoe commented Jan 24, 2022

I've tried the macroexpanded version on ECL.

ECL (Embeddable Common-Lisp) 21.2.1 (git:c646799145538997d84ed6d8755be7e7837eb7ef)
Copyright (C) 1984 Taiichi Yuasa and Masami Hagiya
Copyright (C) 1993 Giuseppe Attardi
Copyright (C) 2013 Juan J. Garcia-Ripoll
Copyright (C) 2018 Daniel Kochmanski
Copyright (C) 2021 Daniel Kochmanski and Marius Gerbershagen
ECL is free software, and you are welcome to redistribute it
under certain conditions; see file 'Copyright' for details.
Type :h for Help.  
Top level in: #<process TOP-LEVEL 0x55c5648bbf80>.

> (declaim (optimize safety))
((OPTIMIZE SAFETY))

> (compile nil '(lambda () (MULTIPLE-VALUE-CALL (LAMBDA (ONE TWO) (LIST ONE TWO)) (VALUES 1 2 3))))
;;; OPTIMIZE levels: Safety=3, Space=0, Speed=3, Debug=0
;;;
;;; End of Pass 1.
#<compiled-function 0x55c565112ac0>
NIL
NIL
> (funcall *)
(1 2)

No error is signaled, which is in violation of CLHS 3.5.1.3. The same behavior occurs in code compiled with default safety.

Created a follow-up issue at https://gitlab.com/embeddable-common-lisp/ecl/-/issues/672

@ruricolist
Copy link
Owner

Thanks for opening the ECL issue.

@phoe
Copy link
Contributor Author

phoe commented Jan 29, 2022

The issue is now fixed in ECL develop. https://gitlab.com/embeddable-common-lisp/ecl/-/issues/672#note_825682518

How long would it be good to wait before merging this? Should the test be marked as failing on ECL until ECL makes another release?

@ruricolist ruricolist merged commit 52180d0 into ruricolist:master Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants