Potentially fixed prefabs dying when referencing stuff outside prefabs

rurre · Feb 29, 2024 · 2b76fb0 · 2b76fb0
1 parent c3a72f4
commit 2b76fb0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/Editor/Copiers/GenericCopier.cs b/Editor/Copiers/GenericCopier.cs
@@ -317,8 +317,11 @@ public static void CopyPrefabs(CopyInstance inst, bool createGameObjects, bool a
                 Component[] prefComponents = toPref.GetComponentsInChildren<Component>(true);
                 foreach(var comp in prefComponents)
                 {
-                     if(fixReferences)
-                        FixReferencesOnComponent(comp, tFrom, tTo, createGameObjects);
+                    if(fixReferences)
+                    {
+                        var refs = GetReferencesToFixLater(comp, tFrom, tTo, createGameObjects);
+                        inst.propertyRefs.Add(refs);
+                    }
 
                      if(adjustScale)
                      {

diff --git a/Editor/Helpers/PumkinsHelperFunctions.cs b/Editor/Helpers/PumkinsHelperFunctions.cs
@@ -1418,7 +1418,7 @@ public static void SelectAndPing(string assetPath)
                     if(newTrans)
                         newComp = newTrans.GetComponent<T>();
                     else if(setNullIfNotFound)
-                        PumkinsAvatarTools.Log($"Couldn't find object for <b>{prop.displayName}</b> in <b>{newHierarchyRoot.name}</b>'s hierarchy", LogType.Warning);
+                        PumkinsAvatarTools.Log($"Couldn't find object for property <b>{prop.propertyPath}</b> in <b>{newHierarchyRoot.name}</b>'s hierarchy", LogType.Warning);
                     else
                         continue;
                 }