Skip to content

Commit

Permalink
lib-test_bitmapc-add-for_each_set_clump-test-cases-checkpatch-fixes
Browse files Browse the repository at this point in the history
ERROR: that open brace { should be on the previous line
torvalds#151: FILE: lib/test_bitmap.c:648:
+static struct clump_test_data_params clump_test_data[] __initdata =
+				      { {{0}, 2, 0, 64, 8, clump_exp1},

ERROR: that open brace { should be on the previous line
torvalds#161: FILE: lib/test_bitmap.c:658:
+	for(i = 0; i < clump_test_data[index].count; i++)
+	{

ERROR: space required before the open parenthesis '('
torvalds#161: FILE: lib/test_bitmap.c:658:
+	for(i = 0; i < clump_test_data[index].count; i++)

ERROR: that open brace { should be on the previous line
torvalds#169: FILE: lib/test_bitmap.c:666:
+static void __init execute_for_each_set_clump_test(unsigned int index)
+{

WARNING: suspect code indent for conditional statements (8, 8)
torvalds#173: FILE: lib/test_bitmap.c:670:
+	for_each_set_clump(start, clump, clump_test_data[index].data,
[...]
+	expect_eq_clump(start, clump_test_data[index].limit, clump_test_data[index].exp,

ERROR: that open brace { should be on the previous line
torvalds#180: FILE: lib/test_bitmap.c:677:
+static void __init test_for_each_set_clump(void)
+{

total: 5 errors, 1 warnings, 174 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/lib-test_bitmapc-add-for_each_set_clump-test-cases.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Syed Nayyar Waris <syednwaris@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
  • Loading branch information
akpm00 authored and sfrothwell committed Nov 8, 2020
1 parent ff3c33b commit 40be9d2
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions lib/test_bitmap.c
Original file line number Diff line number Diff line change
Expand Up @@ -655,8 +655,7 @@ static void __init prepare_test_data(unsigned int index)
int i;
unsigned long width = 0;

for(i = 0; i < clump_test_data[index].count; i++)
{
for (i = 0; i < clump_test_data[index].count; i++) {
bitmap_set_value(clump_test_data[index].data,
clump_bitmap_data[(clump_test_data[index].offset)++], width, 32);
width += 32;
Expand Down

0 comments on commit 40be9d2

Please sign in to comment.