Pin C4 not behaving correctly? Need testing?

[ElDominio]

I have both a revA and a revB with issues on the Launch Control input where it stays engaged no matter what. I haven't been able to test much, but Tercel and Corolla both stay with launch control engaged if I enable launch control. Will update with more tests, but if any bench tests can be done it would be great

[andreika-git]

1. What's the value of the setting 'boardUse2stepPullDown'? Is it "With Pull Down" or "With Pull Up"?

2. And what about revC? Does it work on revC?

[ElDominio]

1. Pretty sure I have it as "With Pullup", since we wired it to a switch to ground

2. Have not tested revC yet

[andreika-git]

1. Does the revB board have the required fix of Q21 transistor? (see C4&C7 pull down mode does not work on rev B #40)

2. Did you set the Launch Control settings correctly?
   a) "Activation Mode" should be set to "Switch Input"
   b) "Switch Input" pin should be set to "C4 - 2STEP"

Currently there is no option for "Switch Input inverted" in the firmware, although we already have "Clutch Input inverted". That's why your switch may act in inverted mode, and launch control may be engaged all the time except when activated. Maybe we should ask @rusefillc to add the inverting pin mode option...

3. Can you please try the "readpin PF11" command in the rusEFI Console? Please run it twice with the switch enabled and disab led. This will check the voltage on the input pin without any Launch Control logic.

[rusefillc]

@ElDominio I've made the change we can now adjust Launch control pin mode

Please update to latest firmware, please select inverted pin mode, please report back.

[rusefillc]

@andreika-git reminded me that we need actual code for that not just UI :)

[ElDominio]

I updated, used it as clutch input and now it works fine

[andreika-git]

It would be great if you could test with the new "Switch input inverted" option too...

[ElDominio]

it disables as an option if i use switch input mode

[andreika-git]

We'll fix it, thanks!

[ElDominio]

That is fixed, but in switch mode it still doesn't listen to what I select. It is active when 5v is present, inactive when GND, and I need the opposite

[ElDominio]

Separate issue rusefi/rusefi#4085

Separate issue rusefi/rusefi#4086

[rusefillc]

its greyed but still selected. you need to fully unselect when changing mode

[rusefillc]

OK so original problem is that we launch button "inverted" is missing!

should be

and we have

[rusefillc]

@ElDominio just added logic to hand the new "inverted" flag.

Overall we have three things for each switch:

1. pin
2. inverted or not
3. physical pull ups

[rusefillc]

@ElDominio how does it look with latest changes?

[rusefillc]

closing for now?

[ElDominio]

New update is great and works great 😁